Re: [eigen] GivensQR

[ Thread Index | Date Index | More Archives ]

Thanks a lot!

> Pros:
> The computation of Q is performed only if strictly needed; by default (by
> the constructor) no computation is performed. Q is computed only if the user
> requests it.

that's something we'll have to uniformize across various
decompositions later on.
Actually I believe that the default should be "convenient but not
fast" i.e. compute Q, with an option to not compute Q. But we had yet
to discuss that on the list.

> The main algorithm (Givens rotations application) is written four times with
> small differences: one alteration in this algorithm requires actually four
> modification in the source.

Don't worry about that, we have new generic code for Jacobi rotations
which are just the same so i'll make your code use them.

OK, for the rest, i need to take a deeper look when i have time, but
thanks for your code, it's a good starting point and will same me lots
of time.

I'll polish and include it as soon as possible...


Mail converted by MHonArc 2.6.19+