| Re: [eigen] [patch] Missing function in StdVector |
[ Thread Index |
Date Index
| More lists.tuxfamily.org/eigen Archives
]
- To: eigen@xxxxxxxxxxxxxxxxxxx
- Subject: Re: [eigen] [patch] Missing function in StdVector
- From: Benoit Jacob <jacob.benoit.1@xxxxxxxxx>
- Date: Wed, 6 May 2009 15:35:51 +0200
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:content-type :content-transfer-encoding; bh=yIScR4Ad8vvBXnSjowo8baUaInPL0dhjbcUla36bnJg=; b=Di9Il/C2PTp3OBdjiqKpKJbFnKA1Atxmxefx/S1kJqVc6/UKu9/cGzv8gzDMdLeQ9l xMusAlJ+sno58siJNpaGGz0EODgsoWBGLe8RRJWYGrBvyjs9FQEPgVqvc+KLTeETVhuK z/hzQwIQfge3X9rzNsK0rv3SbBa4JyWDdSwvU=
- Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type:content-transfer-encoding; b=TRV6An/vT8BJInpjzrNF2jjheVT56gEezx/A6gBjmU2RQgJ+hDRr4VTamFUZaCRdEz mM92Idv7OgnYXtMvIyrL35WMZkVkH07mzjrkhqtn1fbrblFwbEJJ5Mibx/sUVKmS6dF9 +TfVdeA90I3Xxpo0xq5BXTmyAuKqe9YgXkf2U=
oops, and here's the diff
Index: Eigen/StdVector
===================================================================
--- Eigen/StdVector (révision 964038)
+++ Eigen/StdVector (copie de travail)
@@ -105,6 +105,8 @@
}
void push_back(const value_type& x)
{ vector_base::push_back(x); }
+ template<class _Iter> void insert(const_iterator position, _Iter
first, _Iter last)
+ { return vector_base::insert(position, first, last); }
iterator insert(iterator position, const value_type& x)
{ return vector_base::insert(position,x); }
iterator insert(iterator position, size_type new_size, const value_type& x)
2009/5/6 Benoit Jacob <jacob.benoit.1@xxxxxxxxx>:
> Thanks, commited (please check the diff below)
>
> By the way, why does StdVector have no copyright/license?
> I know other global headers have none, but that's only because they're
> trivial files.
> Actually, Core is no longer trivial so it should also have a license.
>
> For StdVector I'm not sure who owns a copyright? So please do it...
>
> Benoit
>
> 2009/5/6 Hauke Heibel <hauke.heibel@xxxxxxxxxxxxxx>:
>> Nothing major, just required
>>
>> template<class _Iter> void insert(const_iterator position, _Iter
>> first, _Iter last)
>>
>> for the unit tests to compile under windows.
>>
>> Regards,
>> Hauke
>>
>