|Re: [eigen] Unifying decomposition interfaces|
[ Thread Index |
| More lists.tuxfamily.org/eigen Archives
- To: eigen@xxxxxxxxxxxxxxxxxxx
- Subject: Re: [eigen] Unifying decomposition interfaces
- From: Hauke Heibel <hauke.heibel@xxxxxxxxxxxxxx>
- Date: Thu, 21 May 2009 22:14:09 +0200
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:content-type :content-transfer-encoding; bh=dF+IORTpsjNbXLMFYprb88tilGo0WSQqHTFaBR3fjmo=; b=M4CPA1Cqczl89vDFbLoQsgWKjHqHv27k4/ob7VWvZwFBCrRcB5rBFVmws6SHgNrRlV /z0XY4XYodMlJlSz0qEvTC1nn8nF7XPDpxBE0ptnSVMEPp6YBI5qnnoImYIupc2Hbdw7 i6uLJFSgw6qulOHgrK7UIGWpr/gcJz2n0PBDg=
- Domainkey-signature: a=rsa-sha1; c=nofws; d=googlemail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type:content-transfer-encoding; b=U42yvo2QVbhNZI/KgHZ2clGoAO6jU07ODB8h2G+Pda7vA6wI9wOF1YteWgiXiaZqkL jd2YcAVzMv/bqkDc/IRqqRfg4akt8H416sLUKkxPQh7TCiJ8sn/C+QgXPyK3C3PkbAns EZ6djYf23EyD4/LPe7t3Qz5kAxZc1TQe99gTs=
On Thu, May 21, 2009 at 5:42 PM, Benoit Jacob <jacob.benoit.1@xxxxxxxxx> wrote:
> So there's no way around adding bool m_initialized in general. On
> second thought, this also makes code easier to read.
> (Side note: our unit tests for lu and qr currently only test
> dynamic-size, that's bad)
I just added fixed size tests - at least for the assert verifications.
> Another small remark is that the default constructors you added need
> to have some (even very short) documentation. It's just scary for the
> user when an item is undocumented.
A final comment. I did not touch the SelfAdjointEigenSolver - it
already has several undocumented ctors and I am not sure about the use
cases for them.
You can take a look at the final patches over here:
I tried out the patch queues - IMHO, they rock. Only patches will be
versioned in a patch queue - i.e. you are actually working on shallow
copy of the Eigen repository. Each patch in a patch series can be
pushed/poped and modified until you like them. Even now, in case you
have some remarks left, the patches can be easily changed.
Once I get the go, the I will apply the patches - my assumption is
that it will result in four individual commits which I consider
reasonable given the number of changes. If you want a single commit
for the changes just let me know.
p.s. When I have time, I can write a how-to for the patch queues
though the introduction given here is very good