Re: [eigen] sse asin implementation

[ Thread Index | Date Index | More lists.tuxfamily.org/eigen Archives ]


Gael:
I think your idea of the unsupported/MoreVectorization module is a good one.
Anyway, since you mentioned asin in the todo in the first place,
please decide where to put Rohit's code, I'm OK either way.

About --ffast-math, I'm not competent. As soon as one uses SSE, one is
no longer IEEE754 compliant anyway. So pushing the conservative logic
to the extreme, one would disable vectorization unless -ffast-math is
enabled. So it's really a matter of measuring how much imprecise our
fast functions are. If it's just 1 bit of imprecision, then it doesn't
really matter. But if in certain cases the imprecision becomes worse,
then yes restrict that to when -ffast-math is set.

Cheers,
Benoit

2009/4/7 Rohit Garg <rpg.314@xxxxxxxxx>:
> So will it be commited?
>
> On Thu, Apr 2, 2009 at 12:10 PM, Rohit Garg <rpg.314@xxxxxxxxx> wrote:
>> <snip>
>>> it is relevant. Since I'm fine with both behavior I need people
>>> express their opinion to make that change or not. So I count one vote
>>> to "disable by default unless -ffast-math is set".
>>
>> I vote for "disable by default unless -ffast-math is set" as well.
>>
>>
>> --
>> Rohit Garg
>>
>> http://rpg-314.blogspot.com/
>>
>> Senior Undergraduate
>> Department of Physics
>> Indian Institute of Technology
>> Bombay
>>
>
>
>
> --
> Rohit Garg
>
> http://rpg-314.blogspot.com/
>
> Senior Undergraduate
> Department of Physics
> Indian Institute of Technology
> Bombay
>
>
>



Mail converted by MHonArc 2.6.19+ http://listengine.tuxfamily.org/