Re: [eigen] patch to throw std::bad_alloc

[ Thread Index | Date Index | More Archives ]

2008/12/16 Kenneth Riddile <kfriddile@xxxxxxxxx>:
> "The alloca() function is machine and compiler dependent. On many systems its implementation is buggy. Its use is discouraged."
> I know you said you're only using it on *nix platforms, which is good, because the Microsoft alloca() behaves a lot differently than the GCC implementation in that it DOES throw an implementation-defined exception.  Something to think about, but, if I can disable it, then that's good enough for me.

Actually we're more restrictive than that, we use alloca() only on
Linux, where it is fine. I've heard that alloca() is buggy even on
many other unix platforms.

> Ah, yes, that was unintentional and simply a result of different coding styles.  I'm more used to wrapping the contents of a file in the appropriate namespace blocks instead of wrapping the #include since it simplifies maintenance (reduces unintentional namespace pollution and ensures that moving an #include doesn't subtly alter the meaning of that file's contents).

Sure, Eigen is just very special in this respect since so much code is
in headers. The current scheme reduces a lot the amount of namespace{}
statements and centralizes them all in a single place, the public



Mail converted by MHonArc 2.6.19+