| Re: [eigen] MSVC build errors |
[ Thread Index |
Date Index
| More lists.tuxfamily.org/eigen Archives
]
Quoting Patrick Spendrin <ps_ml@xxxxxx>:
ok, thanks again for all the fixing - I have another patch which I need
to compile - but I don't dare to clean it up and commit it as it seems
wrong.
I hope you can do something with this patch.
Your patch is in fact very right, so I committed it (r850479):
- the fact that you could comment out the friend declaration shows
that we no longer need it (i had been thinking about that a while ago
but forgot) so let's just remove it.
- as you saw the asm is used only for comments, i suppose it's a
nonstandard GNU extension and so it's OK to have it different with MSVC;
Cheers,
Benoit
----------------------------------------------------------------
This message was sent using IMP, the Internet Messaging Program.