[ Thread Index |
Date Index
| More lists.liballeg.org/allegro-developers Archives
]
On Fri, 28 Feb 2014 17:13:22 -0700, "Trent Gamblin" <trent@xxxxxxxxxx> wrote:
> Since this is about the hundredth time I've asked for comments, and the
> hundredth time I've not received any, it seems futile to post to this list.
> Any time someone asks for comments I give them, and any time anyone asks for
> testing I do it. Since it's not working both ways, there's no point in me
> asking anything of anyone here anymore. And since when I go ahead and do
> something without asking, Peter "beautifies" the code and adds new problems
> in the process, I think it might be best for me to just fork Allegro
> privately on my own. It would make for a lot less hassles for me, that's for
> sure. So if you don't mind, please remove me from the developer list, revoke
> my access etc. and I'll go my own way.
Trent,
I didn't respond immediately because I simply don't know. I don't do
any OpenGL programming except when I need to for Allegro so it's never
fresh in my mind. In this case I don't have access to the hardware,
I've never seen the problem, I don't know what the problem is. I left
the workaround there because it didn't seem to make things any worse
when I tested with the device that I *do* have. Your guess will be
better than mine. If you want my uninformed opinion: delete the
workaround.
I always try to leave code in a better state than it was, and I fix
significantly more bugs than I make. Often I end up fixing quite old
bugs, too, because nobody else was looking and no bug was reported.
I don't appreciate you calling my contributions into question.
I do appreciate the work you've done, and I hope you will choose to
continue.
Peter
>
> Thanks,
> Trent
>
> -----Original Message-----
> From: Trent Gamblin [mailto:trent@xxxxxxxxxx]
> Sent: February 27, 2014 11:21 AM
> To: 'Allegro Development'
> Subject: [AD] Android Locking
>
> So this code in ogl_lock_es.c:
>
> /* Some Android devices only want to read POT chunks with glReadPixels.
> * This adds yet more overhead, but AFAICT it fails any other way.
> * Test device was gen 1 Galaxy Tab. Also read 16x16 minimum.
> *
> * XXX Nexus 7 at least does NOT require the next POT
> */
> if (IS_ANDROID) {
> glPixelStorei(GL_PACK_ALIGNMENT, 4);
> e = glGetError();
> if (e) {
> ALLEGRO_ERROR("glPixelStorei failed (%s).\n",
> _al_gl_error_string(e));
> ok = false;
> }
>
> w = pot(w);
> while (w < 16) w = pot(w+1);
> h = pot(h);
> while (h < 16) h = pot(h+1);
> ALLEGRO_DEBUG("roundup w, h = %d, %d\n", w, h);
> }
>
> Is supposed to fix locking on some older Androids. I've been testing on a
> couple newer devices (I think they're both Snapdragon), and not only is it
> not needed but it screws up results. Not sure but it seems to be a wrong
> pitch or something. Completely removing this fixes it. Ideally we could fix
> for those old devices and the newer ones but to me this code is just so
> complex to wrap my head around. Maybe Peter you can spot the problem? I'd
> like to test it on Tegra hardware and see if it works with these lines
> removed. If not I'd like to fix it so it works with both old and new but if
> it does work, should I just remove this code? I don't imagine many people
> are still using Android 2.x devices anymore.
>
> Thanks,
> Trent
>
>
>
> ----------------------------------------------------------------------------
> --
> Flow-based real-time traffic analytics software. Cisco certified tool.
> Monitor traffic, SLAs, QoS, Medianet, WAAS etc. with NetFlow Analyzer
> Customize your own dashboards, set traffic alerts and generate reports.
> Network behavioral analysis & security monitoring. All-in-one tool.
> http://pubads.g.doubleclick.net/gampad/clk?id=126839071&iu=/4140/ostg.clktrk
> --
> https://lists.sourceforge.net/lists/listinfo/alleg-developers
>
>
> ------------------------------------------------------------------------------
> Flow-based real-time traffic analytics software. Cisco certified tool.
> Monitor traffic, SLAs, QoS, Medianet, WAAS etc. with NetFlow Analyzer
> Customize your own dashboards, set traffic alerts and generate reports.
> Network behavioral analysis & security monitoring. All-in-one tool.
> http://pubads.g.doubleclick.net/gampad/clk?id=126839071&iu=/4140/ostg.clktrk
> --
> https://lists.sourceforge.net/lists/listinfo/alleg-developers