Re: [AD] Teaching CMake to generate files

[Peter Wang <novalazy@xxxxxxxxxx>]

On Sun, 29 Jul 2012 18:31:03 +0200, Tobias Hansen <tobias.han@xxxxxxxxxx> wrote:
> Am 14.07.2012 03:29, schrieb Peter Wang:
> > On Thu, 12 Jul 2012 21:09:41 +0200, Tobias Hansen <tobias.han@xxxxxxxxxx> wrote:
> >> [2] require-directx_shaders.c-only-on-windows.patch
> > 
> > The implementation is guarded out anyway.
> > I don't see the point in duplicating the logic.
> 
> It allows us to delete the file.

Why?  Because it partly contains precompiled code?

> >> [3] let-cmake-generate-files.patch
> > 
> > It wants to regenerate the files every time I run make.
> > Also it introduces a deviation into the build system.
> > Codifying the command lines into the build system is nice,
> > but I won't commit it in this form.
> > 
> > Perhaps as a manual target to be run by developers or distributors?
> > Then the following patches wouldn't really be necessary as the generated
> > files could be written to the current locations.
> 
> A manual target doesn't help me, because then the generated files would
> still be required to run cmake.

I added a simple shell script instead.

> I hope you apply the following patches from
> 
> http://anonscm.debian.org/gitweb/?p=pkg-games/allegro5.git;a=tree;f=debian/patches;hb=HEAD
> 
> require-directx_shaders.c-only-on-windows.patch

Fine.  But I don't agree, and I need a reason to put in the log message.

> let-cmake-generate-files.patch

This patch is too ugly (and incomplete, I think) hence the shell
script.

> rename-scanline_drawers.c-to-scanline_drawers.inc.patch

Applied.

Peter