Re: [AD] monochrome 8x8 builtin font + upscaling algorithm

[Dennis-Busch@xxxxxxxxxx]

On 10 Jul 2012 at 21:38, Peter Wang wrote:
> On Mon, 09 Jul 2012 17:35:52 +0200, Dennis-Busch@xxxxxxxxxx wrote:
> > The only public function is now:
> > ALLEGRO_FONT *al_create_builtin_font(void);
> 
> That looks fine to me.
> 
> Since you seem to be sending a few patches, I'm going to nitpick the
> patch.

Thanks. Attached is a new patch which addresses everything you 
pointed at (unless I overlooked some detail).

> Make use of multiple lines in the log message.

I'm pretty sure I did but the .patch file generator (from 
TortoiseGIT) seems to ignore the line breaks to create a single 
subject line.
This time I edited the patch file to put the line breaks back in, I 
wasn't sure whether the "[PATCH]" part at the beginning was required 
or not so I left it in.

> Style.
> 
> a4f and a5fbuiltin are pretty ugly variable names.

The a4f was already there when I found the code. 
Anyway, changed both now.

Dennis Busch
d_busch@xxxxxxxxxx

The following section of this message contains a file attachment
prepared for transmission using the Internet MIME message format.
If you are using Pegasus Mail, or any other MIME-compliant system,
you should be able to save it or view it from within your mailer.
If you cannot, please ask your system administrator for assistance.

   ---- File information -----------
     File:  0001-simple-builtin-8x8-font-creation-function.patch
     Date:  11 Jul 2012, 16:36
     Size:  30698 bytes.
     Type:  Unknown

Attachment: 0001-simple-builtin-8x8-font-creation-function.patch
Description: Binary data