Re: [AD] tests on OS X (was Re: SF.net SVN: alleg:[15387] allegro/branches/5.1/src/opengl)

[Peter Wang <novalazy@xxxxxxxxxx>]

On Fri, 24 Feb 2012 20:34:49 +0100, Elias Pschernig <elias.pschernig@xxxxxxxxxx> wrote:
> On Fri, 24 Feb 2012 17:02:14 +1100
> Peter Wang <novalazy@xxxxxxxxxx> wrote:
> 
> > On Thu, 23 Feb 2012 20:00:59 -0700, Trent Gamblin <trent@xxxxxxxxxx>
> > wrote:
> > > I got rid of the errors in test_locking2. I still have 6 errors,
> > > does that sound about right? That's not counting test_fonts or
> > > test_prim because those don't run for me (can't load a4_font.tga
> > > and 'undefined' draw_pieslice.)
> > 
> > [moving to AD]
> > 
> > All the tests pass on Linux and Windows (D3D and GL) so I assumed it
> > was fine on OS X as well.  Perhaps Elias knows?
> > 
> > I assume the a4_font.tga failure is just that the example data hasn't
> > been copied into place by make copy_example_data.  I'll look to
> > improve that later.
> > 
> > No idea about draw_pieslice.  Do you mean the linker is failing to
> > resolve that symbol?
> > 
> 
> It fails here as well. I just ran it and copied to
> http://allegro5.org/tests.py
> 
> http://alleg.de/tests/run%20on%202012-02-24%2000:30osx/test_out.txt
> http://alleg.de/tests/run%20on%202012-02-24%2000:30osx/test%20pieslice%20%5Bhw%5D.png
> http://alleg.de/tests/run%20on%202012-02-24%2000:30osx/test%20pieslice%20%5Bsw%5D.png
> 
> Not sure why it fails, the only difference is that in software mode a
> pixel is missing.

I see another pixel difference near the top left of the green slice.

BTW, a way to check differences is to load two images as separate layers
in the Gimp (or something) and use a Difference blender.  Grain extract
seems to work even better.

> 
> The other failing tests are:
> 
> http://alleg.de/tests/run%20on%202012-02-24%2000:30osx/test%20texture%20rw%2015b%20BGR_555%20%5Bsw%5D.png
> http://alleg.de/tests/run%20on%202012-02-24%2000:30osx/test%20texture%20rw%2015b%20BGR_555%20%5Bhw%5D.png
> 
> http://alleg.de/tests/run%20on%202012-02-24%2000:30osx/test%20texture%20rw%2015b%20RGB_555%20%5Bsw%5D.png
> http://alleg.de/tests/run%20on%202012-02-24%2000:30osx/test%20texture%20rw%2015b%20RGB_555%20%5Bhw%5D.png
> 
> http://alleg.de/tests/run%20on%202012-02-24%2000:30osx/test%20texture%2015b%20BGR_555%20%5Bsw%5D.png
> http://alleg.de/tests/run%20on%202012-02-24%2000:30osx/test%20texture%2015b%20BGR_555%20%5Bhw%5D.png
> 
> http://alleg.de/tests/run%20on%202012-02-24%2000:30osx/test%20texture%2015b%20RGB_555%20%5Bsw%5D.png
> http://alleg.de/tests/run%20on%202012-02-24%2000:30osx/test%20texture%2015b%20RGB_555%20%5Bhw%5D.png

Perhaps something to do with GL_ALPHA_BIAS?

> 
> http://alleg.de/tests/run%20on%202012-02-24%2000:30osx/test%20png%20indexed%20%5Bsw%5D.png
> http://alleg.de/tests/run%20on%202012-02-24%2000:30osx/test%20png%20indexed%20%5Bhw%5D.png
> 
> http://alleg.de/tests/run%20on%202012-02-24%2000:30osx/test%20bmp%20indexed%20%5Bsw%5D.png
> http://alleg.de/tests/run%20on%202012-02-24%2000:30osx/test%20bmp%20indexed%20%5Bhw%5D.png

Missing implementation of ALLEGRO_KEEP_INDEX.

> 
> http://alleg.de/tests/run%20on%202012-02-24%2000:30osx/test%20png%20%5Bsw%5D.png
> http://alleg.de/tests/run%20on%202012-02-24%2000:30osx/test%20png%20%5Bhw%5D.png
> 
> http://alleg.de/tests/run%20on%202012-02-24%2000:30osx/test%20tga%20%5Bsw%5D.png
> http://alleg.de/tests/run%20on%202012-02-24%2000:30osx/test%20tga%20%5Bhw%5D.png

Ugh, try changing the lines in the OS X native image loader from:

    r *= 255 / a;

to

    r = r * a / 255;

like the other loaders have.

> 
> http://alleg.de/tests/run%20on%202012-02-24%2000:30osx/test%20blend%20add%20src_one%20%5Bsw%5D.png
> http://alleg.de/tests/run%20on%202012-02-24%2000:30osx/test%20blend%20add%20src_one%20%5Bhw%5D.png

Possibly the same problem with the alpha channel.

Peter