Re: [AD] About colors

[ Thread Index | Date Index | More lists.liballeg.org/allegro-developers Archives ]


On 14 Jun 2010, at 9:35 , Peter Wang wrote:
> I'm not in favour of changing it.  al_color_from_rgb seems too long for
> such a common function, and we *are* trying to avoid trivial changes
> now.  I don't see anything particularly wrong as it is.

This is true and we should avoid trivial changes. However, we should also check that the API naming scheme is consistent and doesn't need tweaking because this is the last chance we have of fixing them.
I agree al_color_from_rgb() is longish, but then again I'd probably type that once and then do al_col^N.
I don't have a particularly strong urge either way, but I do think al_color_from_rgb() is a slightly nicer name and would fit in a bit nicer with al_color_from_name() (if it were called that). If there's a majority who wants to change it, then I think we probably should.
On the other hand, if this is the only thing that we have to worry about before we call it 5.0, then I guess we're pretty much done. It's not a "has to be done before 5.0 can be released" type of thing, just a "if we want to do this, we should do it now" type of thing.

Evert



Mail converted by MHonArc 2.6.19+ http://listengine.tuxfamily.org/