| [AD] [ alleg-Bugs-2971924 ] setup/setup is built with insecure RPATH |
[ Thread Index |
Date Index
| More lists.liballeg.org/allegro-developers Archives
]
- To: noreply@xxxxxxxxxx
- Subject: [AD] [ alleg-Bugs-2971924 ] setup/setup is built with insecure RPATH
- From: "SourceForge.net" <noreply@xxxxxxxxxx>
- Date: Wed, 17 Mar 2010 12:33:11 +0000
Bugs item #2971924, was opened at 2010-03-17 14:33
Message generated for change (Tracker Item Submitted) made by ssuominen
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=105665&aid=2971924&group_id=5665
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Samuli Suominen (ssuominen)
Assigned to: Nobody/Anonymous (nobody)
Summary: setup/setup is built with insecure RPATH
Initial Comment:
By default, setup/setup doesn't install to system even if WANT_X11 is set to ON in cmake. And since it's not installed, it's left by insecure RPATH in the binary.
I suggest adding some install commands to it... In Gentoo Linux, we install it like following:
- Install setup/setup to /usr/bin/allegro-setup (because setup is too common name)
- Install keyboard.dat, language.dat and setup/setup.dat to /usr/share/allegro
- Install misc/icon.png to /usr/share/pixmaps/allegro.png
And then create a freedesktop.org compatible .desktop entry for it, into /usr/share/applications/allegro-setup.desktop, like this:
[Desktop Entry]
Name=Allegro Setup
Type=Application
Exec=allegro-setup
TryExec=allegro-setup
Icon=allegro
Categories=Settings;
As a workaround, because of the missing installation handling, I'm also adding:
--- setup/CMakeLists.txt
+++ setup/CMakeLists.txt
@@ -1,3 +1,5 @@
+set(CMAKE_SKIP_BUILD_RPATH TRUE)
+
add_our_executable(setup setup.c)
copy_files(copy_setup_data setup.dat)
above line to setup/CMakeLists.txt, but this should not be required if the CMakeLists.txt is equipped with proper install commands
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=105665&aid=2971924&group_id=5665