[AD] [ alleg-Bugs-1828479 ] Negative parameter in play_sample

["SourceForge.net" <noreply@xxxxxxxxxx>]

Bugs item #1828479, was opened at 2007-11-08 20:37
Message generated for change (Settings changed) made by eglebbk
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=105665&aid=1828479&group_id=5665

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Windows
Group: None
>Status: Closed
Resolution: Invalid
Priority: 5
Private: No
Submitted By: alphabetadragon (alphabetadragon)
Assigned to: Nobody/Anonymous (nobody)
Summary: Negative parameter in play_sample

Initial Comment:
Using a negative value in the third parameter (the pan control) of play_sample causes a crash in the Windows version of the library (even under debug library). Haven't tested on other OS.

eg:

play_sample(sample, sfx_volume, -1,  1000, FALSE);

will crash.

Would suggest correction either by:
- Clipping value to the supported range, or
- Checking with ASSERT in the Debug version of the library.



----------------------------------------------------------------------

Comment By: Milan Mimica (mmimica)
Date: 2008-01-22 19:32

Message:
Logged In: YES 
user_id=1171214
Originator: NO

There is an ASSERT in play_sample(), file sound.c that is triggered.


----------------------------------------------------------------------

Comment By: Jon Rafkind (kazzmir)
Date: 2007-11-12 04:11

Message:
Logged In: YES 
user_id=490770
Originator: NO

FWIW, this does not crash in linux.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=105665&aid=1828479&group_id=5665