| Re: [AD] SF.net SVN: alleg:[11244] allegro/branches/4.9 |
[ Thread Index |
Date Index
| More lists.liballeg.org/allegro-developers Archives
]
- To: "Coordination of admins/developers of the game programming library Allegro" <alleg-developers@xxxxxxxxxx>
- Subject: Re: [AD] SF.net SVN: alleg:[11244] allegro/branches/4.9
- From: "Milan Mimica" <milan.mimica@xxxxxxxxxx>
- Date: Mon, 1 Dec 2008 09:24:22 +0200
2008/12/1 Evert Glebbeek <eglebbk@xxxxxxxxxx>:
> On 30-Nov-08, at 2:45 PM, mmimica@xxxxxxxxxx wrote:
>> /* Put the contents back to the bitmap. */
>> - bitmap->format = tmp->format;
>> - bitmap->flags = tmp->flags;
>> - bitmap->pitch = tmp->pitch;
>> - bitmap->display = NULL;
>> - bitmap->locked = false;
>> - bitmap->w = tmp->w;
>> - bitmap->h = tmp->h;
>> - bitmap->cl = tmp->cl;
>> - bitmap->ct = tmp->ct;
>> - bitmap->cr = tmp->cr;
>> - bitmap->cb = tmp->cb;
>> - bitmap->parent = NULL;
>> - bitmap->xofs = bitmap->yofs = 0;
>> - bitmap->memory = tmp->memory;
>> + memcpy(bitmap, tmp, tmp->size);
>
> Is this correct? The original code copied some elements from tmp and
> set some of them to 0, the new code copies all of them from tmp.
Yeah, those are NULL as well in tmp.
--
Milan Mimica
http://sparklet.sf.net