Re: [AD] fshook patch

[ Thread Index | Date Index | More lists.liballeg.org/allegro-developers Archives ]


On Monday 06 October 2008, Peter Wang wrote:
> On 2008-10-06, Thomas Fjellstrom <tfjellstrom@xxxxxxxxxx> wrote:
> > Attached is the (large) diff I generated using 'svn diff', let me know if
> > theres any problems. Or if its ok for me to merge fshook into 4.9. If its
> > ok, the fshook history is a bit of a mess, so I suppose it doesn't matter
> > if we merge, or just apply the patch.
>
> Thanks for that.
>
> It looks *mostly* okay (only really skimmed it at this point).
> Some minor things but we can fix those afterwards.
>
> But, there are some changes that shouldn't be there, e.g. in
>     CMakeLists.txt,
>     readme_a5.txt,
>     addons/kcm_audio/CMakeLists.txt,
>     addons/acodec/CMakeLists.txt
>
> I'm not sure the FSHOOK-TODO should be there either.

Yeah, if I apply I'll weed out stuff like FSHOOK-TODO. I'll look at the 
others, but I think some CMakeList changes are needed, which specifically are 
you against?

I have a small cmake lists fix comming in my branch asap too..

> Peter
>
>
> -------------------------------------------------------------------------
> This SF.Net email is sponsored by the Moblin Your Move Developer's
> challenge Build the coolest Linux based applications with Moblin SDK & win
> great prizes Grand prize is a trip for two to an Open Source event anywhere
> in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/


-- 
Thomas Fjellstrom
tfjellstrom@xxxxxxxxxx




Mail converted by MHonArc 2.6.19+ http://listengine.tuxfamily.org/