| Re: [AD] Possible bug in 4.2 bitmap loading code. |
[ Thread Index |
Date Index
| More lists.liballeg.org/allegro-developers Archives
]
On 2008-03-23, David Capello <davidcapello@xxxxxxxxxx> wrote:
> On Sun, Mar 23, 2008 at 9:28 PM, Peter Wang <novalazy@xxxxxxxxxx> wrote:
> > I am not sure why biHeight is left as an `unsigned long'. Shouldn't it just be
> > changed to `signed long' and then we can get rid of the int casts?
>
> OK, I put it as a 'signed long' in BITMAPINFOHEADER and WINBMPINFOHEADER
> (OS/2 can't be negative, so it stays as an 'unsigned short').
>
> Attached the new patch that fix problems to load
> bitmaps from the bmp-suite of Jason Summers.
>
> http://www.dacap.com.ar/bmpbug2.zip
Thank you for the patch. It will be committed to 4.3.10plus and 4.9.
Sorry for the delay.
> There are another issue, MSDN says that an BMP can't be
> 'top-down' and 'compressed' at the same time, but with Adobe
> Photoshop you can create them (RLE4 or RLE8, with negative
> height). ¿We should give support to load these top-down
> compressed files? I think that most programs don't support
> these odd files.
What do we do now?
Peter