Re: [AD] Patch for makefile issue when compiling MSVC with Cygwin

[ Thread Index | Date Index | More lists.liballeg.org/allegro-developers Archives ]


On 22/12/06, Andrei Ellman <ae-a-alleg@xxxxxxxxxx> wrote:

I suspect the reason that you could
not get it to work was because the spaces weren't being removed from the
environment variables.

That's right. I use MSVC's vcvars32.bat to set env.

+   # The :msvccommon label of fix.bat includes the following line:
+   # if "%MSVCDir%" == "" set MSVCDir=%VCINSTALLDIR%
+   # Which would make 'ifdef VCINSTALLDIR MSVCDIR_MSVCDIR = $(VCINSTALLDIR)' redundant
+   # However, fix.sh currently does not include this functionality.

Wrong! MSVCDir is not set after fix.bat has been run. It obviously
cannot be set from within the script - a scope issue or something. It
is left blank. This wasn't a problem before since it was unused. The
makefile variable is set in makefile.helper and that should be used.
But this is also fine if can't figure how.

With this patch compiles fine.

--
Milan Mimica
http://sparklet.sf.net




Mail converted by MHonArc 2.6.19+ http://listengine.tuxfamily.org/