Re: [AD] Nokia 770 support patch

[Siarhei Siamashka <siarhei.siamashka@xxxxxxxxxx>]

Peter Wang wrote:

> > The patch which is attached fixes: * problems with image distortion
> >  in 8-bit mode (because of improper alignment in 'ccolconv.c' which
> >  is important for ARM cpu) * crash in FLI playing code * addes
> > ENTER key as fire button to allegro demo game (as Nokia 770 does
> > not have SPACE or CTRL buttons)
> >
> > Also it adds ALLEGRO_ARM define for selecting conditionally 
> > compiled code that should be run on ARM cpu.
>
> Thanks!  Committed.
>
> I would like for someone to check how well the ARM-specific code path
>  in ccolconv.c fares on other architectures.  If the performance is 
> similar to or better than the non-aligned code path then we can 
> remove the #ifdef and settle on the new version.
>
> Oh, I just saw that you volunteered to do this in the a.cc thread :-)
On x86 there does not seem to be any noticeable difference. But as these
sources were initially written by MacOS guys, testing this code makes
sense on ppc arch.

Testing performance of this code can be done by setting 16-bpp desktop
and creating a small test program which initializes 8-bpp windowed mode
and benchmarks blitting to screen.

By the way, in order to make any performance improvements easier to
implement, a better automated performance testing capabilities are
needed. So it might be worth to modify 'test.c' to accept some command
line switches to run benchmarks automatically without any need of user
input, providing log files with the results. So it will be easier to
test 'memmove' patch for performance as well as all the possible
other performance improving patches that will follow.