Re: [AD] minor patches

[ Thread Index | Date Index | More lists.liballeg.org/allegro-developers Archives ]


On 2005-11-27, Elias Pschernig <elias@xxxxxxxxxx> wrote:
> I committed a patch to remove an ASSERT for hsv_to_rgb, since
> there is extra code to find the angle in the 0..360 range if it
> is not after the ASSERT, so it's clearly not needed.

Errr... but you also removed the upper limit. Wouldn't it be better
if you put the assert back with the lower limit extended to whatever
value you have found the algorithm works correctly? (plus document
this feature in the manual).




Mail converted by MHonArc 2.6.19+ http://listengine.tuxfamily.org/