Re: [AD] OSX - joystick fix

[Evert Glebbeek <eglebbk@xxxxxxxxxx>]

On Monday 26 September 2005 21:30, Peter Hull wrote:
> It's quite a big patch. A lot of the source got re-indented by 
> ProjectBuilder as I was editing, so I did a diff -b -B to 'ignore 
> whitespace changes' - hope that's OK.

Well, I don't particularly mind that in itself, but the patch contains 
some... peculiar indenting here and there, for instance:

+  hid_element->max=i_val(element, CFSTR(kIOHIDElementMaxKey));
    type_ref = CFDictionaryGetValue(element, CFSTR(kIOHIDElementNameKey));

(this looks fine in my mail programme, but the addition has a two space 
indent, the existing line a three space indent)

or

+   joy[element->app].stick[element->col].name = name_hat;
+ joy[element->app].stick[element->col].num_axis = 2;

and
-        joy[i].stick[element->stick].axis[element->index].pos = pos;
+   joy[element->app].stick[element->col].axis[element->index].pos = pos;

probably also doesn't cut it.

I sympathise with it being annoying to fix, but could you try to correct 
the patch? Should be doable manually if nescessary (I'd do it myself if I 
had the time), but maybe indent can help too.

Evert