| Re: [AD] XIM patch for Allegro 4.1.x |
[ Thread Index |
Date Index
| More lists.liballeg.org/allegro-developers Archives
]
- To: alleg-developers@xxxxxxxxxx
- Subject: Re: [AD] XIM patch for Allegro 4.1.x
- From: Elias Pschernig <allefant@xxxxxxxxxx>
- Date: Wed, 24 Nov 2004 18:59:04 +0100
- Domainkey-signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:reply-to:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:references; b=ZzECN4v5Jh+EMFjvXFTfekf6PSmbNiLqEpIlu8Qt8Y3qdi+h7RRxiLQL5BceqEezt4SXg2sjjPzLz9My/BNkuElykNlfLAZV/5GiFw+57OTK10qzp4KaAFWCok2detTRmXB7gcKppZXJRZtXDQkackXNPC6fCKXfhjD/Ttr+QV0=
>
> Maybe it's an async error? Dunno. Are you allowed to intermingle X gfx
> calls with X input calls?
>
No, that should produce an async error AFAIK. What I was doing was
different. The input thread gets the X11 keyboard event, and calls the
add_key or similiar function in keyboard.c. This calls the user
keyboard callback. Now in this callback, I was drawing the box of the
pressed key. Because it didn't deadlock immediately, the locks must be
nestable.. so this just did the gfx calls, then returned. The input
thread's X11 lock was held all the time.
The main thread should simply have blocked on its gfx calls - but
yeah, I think some drawing commands don't do proper locking. I think,
for testing, we should have a "disable direct update" config setting,
which disables the direct calls to X11 drawing primitives. Then we
could compare if the crash persists without that.