| Re: [AD] WIP 4.1.15 and CVS freeze |
[ Thread Index |
Date Index
| More lists.liballeg.org/allegro-developers Archives
]
On Fri, 2004-07-23 at 06:47 -0700, Chris wrote:
> Elias Pschernig wrote:
> > Changing rest(long) to rest(unsigned long) makes a lot of sense in my
> > opinion, and will not break old programs (negative numbers never were
> > allowed), so I'm tending to just apply it, and then work on updating the
> > GUI to use rest instead of yield_timeslice.
>
> I would think it'd be better if you made al_rest(unsigned int), and a
> wrapper define that maps rest to al_rest, making sure negative numbers
> get passed as 0 (just in case). AFAIK, the syntax of rest doesn't need
> to change, and the behavior is well-defined (as in, does what people
> need it to), for the most part. So, if you want to start adding prefixed
> functions for a new API, that'd be the best place to start, IMO.
>
Well, there are no backwards compatibility problems with it - so that
would be unnecessary. Changing the parameter to unsigned just fixes the
problem of the undefined behavior with negative numbers. If others think
it shouldn't be done, I'll just put an ASSERT.
--
Elias Pschernig