Re: [AD] Further MIDI fix

[ Thread Index | Date Index | More lists.liballeg.org/allegro-developers Archives ]


Never mind, ignore me.

"A Reset message should never be sent automatically by any MIDI device. 
Rather, this should only be sent when a musician specifically tells a device 
to do so."

So yeah, I think the patch is probably fine and a good idea (though I haven't 
tested it).

Ben

On Wednesday 19 May 2004 23:40, Ben Davis wrote:
> Is there any reason why we can't do a simple MIDI reset?
>
> In a conventional MIDI set-up, the synthesisers will respond to a single
> 0xFF byte as a MIDI reset command; everything will be reset. However, .mid
> files redefine 0xFF as introducing meta-events that need to be processed
> inside the sequencer (e.g. tempo changes).
>
> I haven't looked at how Allegro handles the distinction, but I would
> suggest a 'MIDI reset' feature is important. It could send an 0xFF to the
> actual MIDI device, or, in the case of DIGMID, go systematically through
> all the variables and reset them.
>
> Ref: http://www.borg.com/~jglatt/tech/miditech.htm
>
> Ben
>
> On Wednesday 19 May 2004 22:48, Chris Jones wrote:
> > I hate to be pushy, but any progress on whether this patch is accepted or
> > rejected?
> >
> > > You may remember that about a year ago now a MIDI fix was added to
> >
> > Allegro,
> >
> > > to use the All Sound Off command when a tune ended.
> > >
> > > However, there are still some residual issues if a controller was in
> > > use (eg. sustain) since these are not cancelled at the end of one song
> > > and can affect the next one.
> > >
> > > The proposed fix is to the reset_controllers method in midi.c:
> > >
> > >    if (midi_driver->raw_midi) {
> > >       midi_driver->raw_midi(0xB0+channel);
> > >       midi_driver->raw_midi(10);
> > >       midi_driver->raw_midi(midi_channel[channel].pan);
> > > +      /* All Controllers Off */
> > > +      midi_driver->raw_midi(0xB0+channel);
> > > +      midi_driver->raw_midi(121);
> > > +      midi_driver->raw_midi(0);
> > >    }
> > >
> > > Any opinions?
> > >
> > > cheers,
> > > chris
> > >
> > >
> > >
> > >
> > > -------------------------------------------------------
> > > This SF.Net email is sponsored by Sleepycat Software
> > > Learn developer strategies Cisco, Motorola, Ericsson & Lucent use to
> >
> > deliver
> >
> > > higher performing products faster, at low TCO.
> > > http://www.sleepycat.com/telcomwpreg.php?From=osdnemail3
> > > --
> > > https://lists.sourceforge.net/lists/listinfo/alleg-developers
> >
> > -------------------------------------------------------
> > This SF.Net email is sponsored by: Oracle 10g
> > Get certified on the hottest thing ever to hit the market... Oracle 10g.
> > Take an Oracle 10g class now, and we'll give you the exam FREE.
> > http://ads.osdn.com/?ad_id=3149&alloc_id=8166&op=click
>
> -------------------------------------------------------
> This SF.Net email is sponsored by: Oracle 10g
> Get certified on the hottest thing ever to hit the market... Oracle 10g.
> Take an Oracle 10g class now, and we'll give you the exam FREE.
> http://ads.osdn.com/?ad_id=3149&alloc_id=8166&op=click




Mail converted by MHonArc 2.6.19+ http://listengine.tuxfamily.org/