| Re: [AD] minor bugs report [vers. 4.1.13] |
[ Thread Index |
Date Index
| More lists.liballeg.org/allegro-developers Archives
]
> I've found two configuration bugs in allegro 4.1.13 .
> - configure doesn't accept alsamidi when the ALSA major number is 1
> (instead of 0). This problem can be fixed very easily.
Fixed by attached patch, applied to mainline.
> - if you configure with --enable-color8=no then the macros DR, DG and
> DB get not defined inside the file "src/i386/izbuf.s" and you get a
> link error.
Fixed by attached patch, applied to mainline and 4.0 branch.
--
Eric Botcazou
Index: aclocal.m4
===================================================================
RCS file: /cvsroot/alleg/allegro/aclocal.m4,v
retrieving revision 1.58
diff -u -r1.58 aclocal.m4
--- aclocal.m4 30 Mar 2004 07:02:12 -0000 1.58
+++ aclocal.m4 8 Apr 2004 12:36:22 -0000
@@ -363,7 +363,7 @@
AC_CACHE_CHECK(for supported ALSA version for digital sound,
allegro_cv_support_alsadigi,
AC_TRY_COMPILE([#include <sys/asoundlib.h>
- #if (SND_LIB_MAJOR > 0) || (SND_LIB_MAJOR == 0 && SND_LIB_MINOR == 9)
+ #if (SND_LIB_MAJOR > 0) || (SND_LIB_MAJOR == 0 && SND_LIB_MINOR == 9)
#else
#error
#endif],,
@@ -400,7 +400,7 @@
AC_CACHE_CHECK(for supported ALSA version for MIDI,
allegro_cv_support_alsamidi,
AC_TRY_COMPILE([#include <sys/asoundlib.h>
- #if SND_LIB_MAJOR == 0 && SND_LIB_MINOR == 9
+ #if (SND_LIB_MAJOR > 0) || (SND_LIB_MAJOR == 0 && SND_LIB_MINOR == 9)
#else
#error
#endif],,
Index: src/blit.c
===================================================================
RCS file: /cvsroot/alleg/allegro/src/blit.c,v
retrieving revision 1.12
diff -u -p -r1.12 blit.c
--- src/blit.c 23 Oct 2003 07:56:52 -0000 1.12
+++ src/blit.c 8 Apr 2004 12:39:23 -0000
@@ -311,7 +311,7 @@ static int makecol_dither_trans(BITMAP *
-#ifdef ALLEGRO_COLOR8
+#if (defined ALLEGRO_COLOR8) || (defined GFX_MODEX)
/* dither_blit:
* Blits with Floyd-Steinberg error diffusion.
Index: src/i386/izbuf.s
===================================================================
RCS file: /cvsroot/alleg/allegro/src/i386/izbuf.s,v
retrieving revision 1.7
diff -u -p -r1.7 izbuf.s
--- src/i386/izbuf.s 16 Jul 2003 19:43:28 -0000 1.7
+++ src/i386/izbuf.s 8 Apr 2004 12:39:24 -0000
@@ -138,6 +138,10 @@ FUNC(_poly_zbuf_flat24)
+#define DB -8(%ebp)
+#define DG -12(%ebp)
+#define DR -16(%ebp)
+
#ifdef ALLEGRO_COLOR8
/* void _poly_zbuf_gcol8(unsigned long addr, int w, POLYGON_SEGMENT *info);
* Fills a single-color gouraud shaded polygon scanline.
@@ -192,10 +196,6 @@ FUNC(_poly_zbuf_gcol8)
-#define DB -8(%ebp)
-#define DG -12(%ebp)
-#define DR -16(%ebp)
-
/* void _poly_zbuf_grgb8(unsigned long addr, int w, POLYGON_SEGMENT *info);
* Fills an RGB gouraud shaded polygon scanline.
*/