Re: [AD] little bug

["Javier Gonzalez" <Xavier_Gonzalez@xxxxxxxxxx>]

Ok, here is a revised version, didn't make much, just changed some little
things that I was unsure of from the last patch (I didn't know if releasing
a voice would also unlock its buffer(s), so now I just unlock them before
releasing)

Anyway, about the locking problem, he tested it again and looks like it
didn't totally fix it, but it happens less frequently.


> Hmm, hold on a bit, I think I'm gonna recheck it... :(
>
> > Ok, looks like I fixed it. :D
> > I just modified some things here and there, added some safe checks and
in
> > case why you wonder I specified the buf_b and size_b as NULL, I used
this
> > quote of the directx docs for the lock function, in the remarks section:
> >
> > "If the application passes NULL for the ppvAudioPtr2 and pdwAudioBytes2
> > parameters, the lock extends no further than the end of the buffer and
> does
> > not wrap." <- that is what allegro exactly wants
> >
> > Basically I just made it a bit more error safe
> >
> > Tested by a person having the problem and the input doesn't hang anymore
> for
> > him :)
> > Probably this could also fix some audigy problems Henrik xxx (I don't
> > remember the surname exactly sorry) was reporting long ago
> >
> > Anyway, here is the patch, tested with the digitest program as well
> > It both makes it more stable and adds the GLOBAL_FOCUS fix first
mentioned
> > in the very first little bug mail
> >
> > > > Btw, just to let you know, regarding the choppy input related to
> sound,
> > > > seems like if you use the allegro mixer it doesn't happen
> > > > I'll look into that
> > >
> > > Thanks, you're obviously the specialist of the subject
> >
>
>
>
> -------------------------------------------------------
> This SF.net email is sponsored by:  Etnus, makers of TotalView, The best
> thread debugger on the planet. Designed with thread debugging features
> you've never dreamed of, try TotalView 6 free at www.etnus.com
> -- 
> https://lists.sourceforge.net/lists/listinfo/alleg-developers
>
>

Attachment: wdsound.c.dif
Description: Binary data