Re: [AD] Patches for allegro 4.1.9

[Eric Botcazou <ebotcazou@xxxxxxxxxx>]

> > The function is a method of the INTERNAL_MOUSE_DRIVER class, so we would
> > need to modify every mouse driver.
>
> The question is, if this wouldn't be the cleaner way to deal with it. But
> if you don't want to go that route, there should at least be a check that
> the passed in value isn't negative.

It's an internal method so we're not supposed to be checking everything. I'll 
look into the issue anyway.

> > I hate double-underscored types :-)
>
> Well, C99 has uint32_t .... So you'd prefer to use 'unsigned int' here?

Yep.

> If you use -W -Wall -Werror, unused parameters have to be taken care of or
> alternatively -Wno-unused-parameters be used. In case you don't object,
>
> I could add an ATTRIBUTE_UNUSED to one of the headers that expands to
> __attribute__((unused)) on gcc >= 2.7 and to nothing otherwise. In that
> case all places where unused parameters occur, they would have to be
> marked with ATTIBUTE_UNUSED.

Sorry, I messed it up... Allegro compiles only with -Wall -W -Werror 
-Wno-unused on DOS/Windows so we'll use that for the Unix port too.

-- 
Eric Botcazou