Re: [AD] Patches for allegro 4.1.9

[ Thread Index | Date Index | More lists.liballeg.org/allegro-developers Archives ]


> The second diff (allegro-cleanup.dif) does three things:
>
>   - use 'unsigned long' when doing pointer<->integer casts.
>   - fixes those cases where signed and unsigned where mixed
>     in comparisons and conditional expressions.
>   - provides correct prototypes for declarations and definitions,
>     mostly (void) instead of the incorrect ().

Something I forgot about in my first mail:

--- src/x/xwin.c
+++ src/x/xwin.c
@@ -2178,7 +2178,7 @@
 	 break;
       case ClientMessage:
          /* Window close request */
-         if (event->xclient.data.l[0] == wm_delete_window) {
+         if ((Atom)event->xclient.data.l[0] == wm_delete_window) {
             if (_xwin.close_button_callback)
                _xwin.close_button_callback();

Why to cast to 'Atom'? 'l' is a 'long' according to my docs.

-- 
Eric Botcazou




Mail converted by MHonArc 2.6.19+ http://listengine.tuxfamily.org/