Re: [AD] set_gfx_mode() rewrite

["Eric Botcazou" <ebotcazou@xxxxxxxxxx>]

> Following up on Eric's followup, I've added a gfx_cardf config string.
> With this addition, GFX_AUTODETECT_WINDOWED and GFX_AUTODETECT_FULLSCREEN
> are treated more symmetrically.

The problem is, they aren't really symmetrical because we have ports that
don't support windowed drivers, whereas fullscreen is always supported.

> With the recent addition of -windowed and -fullscreen flags to the
> grabber, this makes sense IMHO.

I'm still not very fond of adding this gfx_cardf variable: doing so may
appear as enforcing consistency, but I think it's not the case. From my
point of view, the legacy gfx_card variable is actually the gfx_cardf
variable, so that GFX_AUTODETECT_FULLSCREEN is associated with gfx_card and
GFX_AUTODETECT_WINDOWED with gfx_cardw, GFX_AUTODETECT being the union of
both.

I propose the patch attached to this message, which more clearly enforces
that: GFX_AUTODETECT_WINDOWED doesn't read the gfx_card variable anymore and
GFX_AUTODETECT reads the gfx_cardw variable if the gfx_card variable failed
to provide it with a working driver.

Moreover I think that, from the user point of view, three variables is too
much.

> Are there any plans to update the setup program to allow the user to
> select the graphics driver? If not, I'll add it to my personal todo list,
> but I'm eager to continue with the grabber first.

This was talked about several times, but never materialized.

--
Eric Botcazou

Attachment: graphics.diff
Description: Binary data