Re: [AD] bugfix in create_video_bitmap()

[ Thread Index | Date Index | More lists.liballeg.org/allegro-developers Archives ]


> It will fail to find an existing free location for a video bitmap in some
> cases when you first create some video bitmaps, then destroy a
> particular subset of them (I can be more specific on request).

Theoritically yes. I have an example too, with 4 bitmaps, in which the first
three ones are destroyed (I suppose yours is similar).

> Probably it doesn't make any big difference in most common cases, because
> you usually allocate a fixed set of video bitmaps in the initialization,
> then keep them forever.

Moreover the problem occurs only if the very first bitmap is destroyed,
which is highly unlikely since it is usually a mere copy of the screen.

> With the attached patch it always finds empty space to put the new
> bitmap in if it exists ("proof": [...])
> I hope that made some sense :-)

Yes, in other words: it is sufficient to test the nodes of the grid made up
of the X-axis, the Y-axis and the straight lines carrying the bottom edge or
the right edge of the bitmaps.

Patch commited.

--
Eric Botcazou
ebotcazou@xxxxxxxxxx



Mail converted by MHonArc 2.6.19+ http://listengine.tuxfamily.org/