Re: [AD] Release Candidate 2

[Laurence Withers <lwithers@xxxxxxxxxx>]

In reply to Eric Botcazou <ebotcazou@xxxxxxxxxx>:
>Here's what BC++ says about makedoc.c:
>Warning W8004 docs\makedoc.c 2040: 'title' is assigned a value that is never
>used in function write_rtf
>Warning W8004 docs\makedoc.c 2019: 'pardebt' is assigned a value that is
>never used in function write_rtf

I have attached a patch which removes the `title' variable altogether,
since it is plainly not used anywhere (it is only ever assigned to; not
from).

Just to check there was no black magic involved, I also ran a `cmp' on
the output from makedoc before/after this patch.

--- makedoc.c.old	Thu Dec  6 15:41:04 2001
+++ makedoc.c	Thu Dec  6 15:41:50 2001
@@ -1562,7 +1562,6 @@
    char *p, *last = 0;
    FILE *f;
    int preformat = 0;
-   int title = 0;
    int prevhead = 0;
    int prevdef = 0;
    int multidef = 0;
@@ -1778,13 +1777,11 @@
 	    else if (strincmp(p, "<title>") == 0) {
 	       /* start document title */
 	       fputs("{\\info{\\title ", f);
-	       title = 1;
 	       p += 7;
 	    }
 	    else if (strincmp(p, "</title>") == 0) {
 	       /* end document title */
 	       fputs("}{\\author Allegro makedoc utility}}\n", f);
-	       title = 0;
 	       p += 8;
 	    }
 	    else if (strincmp(p, "<hr>") == 0) {

As to the `pardebt' variable, I cannot see where the error is being
generated. However, things are confused by use of the PAR() macro and
the fact that the indentation in Allegro is all over the place (makes
complex code unreadable for me).

Bye for now,
-- 
Laurence Withers, lwithers@xxxxxxxxxx
                http://www.lwithers.demon.co.uk/

Attachment: signature.asc
Description: PGP signature