Re: [AD] Dissolve blender, findfirst on MSVC

[ Thread Index | Date Index | More lists.liballeg.org/allegro-developers Archives ]


> When I wrote the blenders so many years ago, I obviously neglected to
> test the dissolve blender, as the opacity polarity is inverted.  It
> should be:

Commited (without the first test).

> Also, findfirst emulation should be enabled for MSVC; MSVC only has
> _findfirst, which has different, poorly-designed semantics, and is
> undocumented.  It doesn't compile out-of-box with ALLEGRO_NO_FINDFIRST
> set.

We just addressed this problem by providing an unified al_find*() mini-API
that is a mix between DJGPP's find*() and MSVC's _find*(): you can specify a
set of attributes to search for (like with the DJGPP version) and the time
format is ANSI time_t (like in the MSVC version).

> It appears that Shawn didn't finish up with this behavior.
> _al_findfirst is the function to link to (src/win/wfile.c and such),
> but if ALLEGRO_NO_FINDFIRST is set it defaults to opendir instead
> (src/libc.c), which MSVC is also lacking.

The preprocessor option ALLEGRO_NO_FINDFIRST doesn't exist any longer.

> The necessary fixes could easily be done without changing the external
> API, but a number of files will be hit, and the implementation is a
> design choice.

The al_find*() functions are now part of the API (although referred to as
"low-level" functions). They were implemented by revamping the (somewhat
strange) interface of the former _al_find*() functions.

--
Eric Botcazou
ebotcazou@xxxxxxxxxx



Mail converted by MHonArc 2.6.19+ http://listengine.tuxfamily.org/