Re: [AD] "clear" work bad with sub-bitmaps

[ Thread Index | Date Index | More lists.liballeg.org/allegro-developers Archives ]



Javier González wrote:
> can someone with good asm knowledge (i only know intel syntax ;) check it?

Fixed.

--
- Robert J Ohannessian

"Microsoft code is probably O(n^20)" (My CS teacher)
--- /allegro/src/i386/iblit8.s	Sat Feb 10 08:20:20 2001
+++ allegro/src/i386/iblit8.s	Sat Feb 10 08:31:30 2001
@@ -108,8 +108,7 @@
 
    addl $8, %edi                 /* we set %edi to the next aligned memory address */
 
-   addl %eax, %ecx               /* and adjust %ecx to reflect the change */
+   addl %eax, %ecx
 
 clearMMX_aligned:
    movl %ecx, %eax               /* save for later */
@@ -195,7 +194,8 @@
 
    addl $8, %edi                 /* we set %edi to the next aligned memory address */
 
-   addl %ecx, %eax               /* and adjust %ecx to reflect the change */
+   addl %eax, %ecx
+
 
 clearMMXseg_aligned:
    movl %ecx, %eax               /* save for later */
--- /allegro/src/i386/iblit16.s	Sun May 14 16:17:14 2000
+++ allegro/src/i386/iblit16.s	Sat Feb 10 08:28:38 2001
@@ -109,7 +109,7 @@
 
    addl $8, %edi                 /* we set %edi to the next aligned memory address */
 
-   addl %eax, %ecx               /* and adjust %ecx to reflect the change */
+   addl %ecx, %eax               /* and adjust %ecx to reflect the change */
 
 clearMMX_aligned:
    movl %ecx, %eax               /* save for later */
@@ -197,7 +197,7 @@
 
    addl $8, %edi                 /* we set %edi to the next aligned memory address */
 
-   addl %ecx, %eax               /* and adjust %ecx to reflect the change */
+   addl %eax, %ecx               /* and adjust %ecx to reflect the change */
 
 clearMMXseg_aligned:
    movl %ecx, %eax               /* save for later */


Mail converted by MHonArc 2.6.19+ http://listengine.tuxfamily.org/