RE: [AD] DIFF for DirectX pageflip fix

["Isaac Cruz" <icruzbal@xxxxxxxxxx>]

----- Original Message -----
From: Robin Burrows <rburrows@xxxxxxxxxx>
To: <conductors@xxxxxxxxxx>
Sent: Saturday, August 26, 2000 7:44 PM
Subject: [AD] DIFF for DirectX pageflip fix


> I would like to submit this diff for evaluation, as I mentioned before,
> it should fix incorrect pageflipping on cards like Voodoo3 and TNT2. I
> really would appreciate feedback and testing on this.
>
> I also made the colour palette setting more accurate (previously the
> maximum 63 value was converted to 252 with <<2).
You have changed the code so it will create the primary surface with a
backbuffer attached isn't it? hmm, I noticed that some drivers (detonator 3.68 I
think, don't know about voodoo3) had a bug when you wanted to attach a
backbuffer once the primary surface was created, but it's now corrected. Also,
with your patch, page flipping will be a little faster, but note that there's
some memory wasted if you don't want to use page flipping (it first tries to
create a primary surface with 2 back buffers). For me it isn't an issue, my card
has 16 megs, but what about the rest of people, what so you think?

Also, what about windowed mode? doesn't it break it? I'm not sure if when you
request a complex primary surface in this case, it will fail and fall back to a
simple primary surface. Have you tried?

OK, it seems a good idea, thanks for it, i will apply it as soon as it's well
tested