[AD] Bugs on the last WIP version of Allegro

["Javi G.G." <javigg@xxxxxxxxxx>]

Ok, here is the whole list of bugs I've founded:

 

The getr15() and getg15() functions doesn't work, but the getr15() works, they return always black

and the value (in this mode) must be between 0-127 (i think it should be between 0-255)

I don't know if this happens in some other color depth modes, but i think it happens.

 

  so check: (alinline.h)

---

AL_INLINE(int, makecol15, (int r, int g, int b),
{
   return (((r >> 3) << _rgb_r_shift_15) |
           ((g >> 3) << _rgb_g_shift_15) |
           ((b >> 3) << _rgb_b_shift_15));
})

---

  and now check:

---

AL_INLINE(int, getr15, (int c),
{
   return _rgb_scale_5[(c >> _rgb_r_shift_15) & 0x1F];
})

 

AL_INLINE(int, getg15, (int c),
{
   return _rgb_scale_5[(c >> _rgb_g_shift_15) & 0x1F];
})

 

AL_INLINE(int, getb15, (int c),
{
   return _rgb_scale_5[(c >> _rgb_b_shift_15) & 0x1F];
})

---

and also check the other depths...

 

  Also when "sneaking" in your allegro/src/c folder, I noticed that the file CBLIT15.C is missed.

  I'm reporting this cause in the folder you always have a c for every the depths avaiable.

  example: cscan.h / cscan8.c cscan15.c cscan16.c cscan24.c

  but you have: cblit.h / cblit8.c cblit16.c cblit24.c (the cblit15.c is missed!)

  (I don't know if I'm wrong, maybe I am...)

 

 

and tips:

 

The file_select select (I think) should use popup_dialog instead of do_dialog (like alert)

and so the gfx_select

Anyway to mantain runnig two dialogs at once (like a menu that opens several dialogs, but

with the menu still functional) Is there anyway?

 

Awaiting your answer

   Javier González