Re: [AD] More Linux patches

[ Thread Index | Date Index | More lists.liballeg.org/allegro-developers Archives ]


George Foot <mert0407@xxxxxxxxxx> writes:

> It also changes misc/deplib.sh to reduce the code duplication,
> which was getting pretty serious.  Michael, is this OK as far as
> portability is concerned?  I used a function.  If it's not OK,
> should we make a separate script to do what the function does?

I think we should leave function and only use separate script
if there will be problems.  I don't remember anything about
portability problems with functions in shell-scripts.

> 
> it incorporates the configure code Michael
> Bukin wrote for defining MAP_FAILED when necessary.

Perhaps, defining MAP_FAILED in source if it is not yet defined would
be better than extra code in configure script.  For instance,
MAP_FAILED can be defined in some header file which is not included
when we test for MAP_FAILED in configure script.

-- 
Michael Bukin



Mail converted by MHonArc 2.6.19+ http://listengine.tuxfamily.org/