Re: [framework-discuss] Codestyle

[ Thread Index | Date Index | More Archives ]

I agree. The codestyle has been mostly untouched since the move from C++ to D yet.

- The documentation is still based on Doxygen. Do we keep using that or do we use DDoc? I believe the latter is more straightforward and streamlined with Dlang.
- Regarding the usage of _ (underscore) in private variables, honestly I'm completely against it. To me it makes little sense this naming scheme.
- I'd prefer to open braces in the same line as the function declaration.
- I'm against adding a space after some keywords (for example, if, while, for, switch)
- The header section on the codestyle is outdated. Honestly it's better to just remove.

On Sat, 12 Oct 2019 at 17:29, Luís Ferreira <luis@xxxxxxxxxxxxxx> wrote:
Hey Team,

I want to open a discussion about the codestyle for the framework and for Aurora project itself.

I have noticed some inconsistency on some points, such as:
  - Tab indentation
  - Variable names for public API and private.
  - And some other codestyle sections you feel uncomfortable with.

My opinion in Tab indentation:
I like the idea of use tabs for indentation and spaces for alignment. For each file extension, we need to define a file on infrastructure repo with the "standard" way of indentation.

Public API and private variables:
This is a thing very inconsistent on Aurora. For private variables, sometimes we use underscore (_), m_ , or even the same as public API.

Let me know your thoughts and make suggestions about this topic.


Mail converted by MHonArc 2.6.19+