| Re: [frogs] Patch for Issue #830 |
[ Thread Index |
Date Index
| More lilynet.net/frogs Archives
]
- To: Carl Sorensen <c_sorensen@xxxxxxx>
- Subject: Re: [frogs] Patch for Issue #830
- From: Neil Puttock <n.puttock@xxxxxxxxx>
- Date: Sun, 20 Dec 2009 18:14:46 +0000
- Cc: Marc Hohl <marc@xxxxxxxxxx>, Lily-Devel List <lilypond-devel@xxxxxxx>, "frogs@xxxxxxxxxxx" <frogs@xxxxxxxxxxx>
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type; bh=bHfX3jRsVfqtFhFK5azgnewTTZd7zLQpvSJ/8FVuQTQ=; b=HVLndTQwudAAsvv8z/Q2eza29c2kdxr+u7SLGddG1Mvlv02X5lmXdYF6/wgsIIW5ke fyuvfZXoi5emg/3TVUPTna+Vpevv5donTRQi8wkx6cf6E0ml/pxPAFB1uJm8zogpIGtn SFzPi+qOcoXpw4qEQPgzXuCa77FNZRRQCJszs=
- Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=OS2M4USzXL0+OaB8MUM1K/huOGmD6JS/gXk7q7L7N98QuJKJJmsKbKNZsmVSlNhumb jRFSuteKYL3RkqvMDpGAg7I64x07kVVEDrZ04sNfbRL9obGnRJapWZT/YYqo8wc4eIEK 5hVLZZ0MhaIZVXsop0x8Kfr3JAs92JR/dRheg=
2009/12/20 Carl Sorensen <c_sorensen@xxxxxxx>:
> I think I'd like to recommend that in the future, instead of emailing
> patches (with the associated problems with line endings), we just have Frogs
> post them on Rietveld.
I'd also recommend at least checking a snippet runs properly (if not
doing a regression test check); an error-free run of make all
certainly isn't enough for such an invasive patch.
warning: time signature symbol `C44' not found; reverting to numbered style
Regards,
Neil
---
----
Join the Frogs!