[frogs] Re: Tracker 836: Add facility to change output file-name for a \book block

[n.puttock@xxxxxxxxx]

Hi Ian,

Carl's already commented on \pitchedTrill, but there's absolutely
nothing wrong with its current indentation; the only thing that you
might change is the newline after the let*.

Regards,
Neil


http://codereview.appspot.com/143055/diff/19/1017
File lily/parser.yy (right):

http://codereview.appspot.com/143055/diff/19/1017#newcode676
Line 676: PARSER->lexer_->set_identifier (ly_symbol2scm
("book-filename"), SCM_BOOL_F);
There are a few spaces between tabs here, i.e.,

[tab][spaces][tab]

iso

[tab][tab][spaces]

http://codereview.appspot.com/143055/diff/19/1019
File ly/music-functions-init.ly (right):

http://codereview.appspot.com/143055/diff/19/1019#newcode16
Line 16: %% TODO: Move this declaration to music-functions.scm
Please remove this completely.

http://codereview.appspot.com/143055/diff/19/1020
File scm/lily-library.scm (right):

http://codereview.appspot.com/143055/diff/19/1020#newcode99
Line 99: (for-each (lambda (symbol)
On 2009/11/04 01:06:34, Patrick McCarty wrote:
> I would recommend indenting like so:

>    (for-each
>      (lambda (symbol)
>        (let ((..

I'd recommend reverting the changes, since there's absolutely nothing
wrong with how this is currently indented. :)

http://codereview.appspot.com/143055

---

----
Join the Frogs!