Re: [frogs] PATCH for getting output-suffix to work (Trackers 714 and 404)

[Reinhold Kainhofer <reinhold@xxxxxxxxxxxxx>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Am Donnerstag, 6. August 2009 18:20:26 schrieb Ian Hulin:
>  Here's the first stage of work on these trackers,  I've taken the work
> Marek Klein did and polished it a little bit. 

Great to see that this is not forgotten (like so many other not yet finished 
patches)! Some comments below...

> +    (if (string? output-suffix)
> +       (set! result (format "~a-~a" base (string-regexp-substitute
> +                                        "[^a-zA-Z0-9-]" "_" output-suffix))))

This rules out any accented or other foreigh letters! E.g. all chinese suffixes 
will simply turn into ______. Also, German instrument names like "Flöte" or 
"Hörner" would become "Fl_te" and "H_rner" in the suffix.

I supose it would be better to use 
  "[^[:alnum:]-+]"
as the regexp to allow all alpha-numeric letters.

>  (define-public (version-not-seen-message input-file-name)
>    (ly:message
> -   "~a:0: ~a: ~a"
> +   "~a:0: ~a ~a"
>      input-file-name
> -    (_ "warning: ")
> +    (_ "warning:")

Nice catch, but has nothing to do with output-suffix, so it should go into its 
own patch.

Cheers,
Reinhold
- -- 
- ------------------------------------------------------------------
Reinhold Kainhofer, reinhold@xxxxxxxxxxxxx, http://reinhold.kainhofer.com/
 * Financial & Actuarial Math., Vienna Univ. of Technology, Austria
 * http://www.fam.tuwien.ac.at/, DVR: 0005886
 * LilyPond, Music typesetting, http://www.lilypond.org
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iD8DBQFKewkITqjEwhXvPN0RAjYEAJ0TaV392KlkU//Xo+iQ45NDN4cIoACfeugc
7Xe8HmcDYvOtpTpWso0nDug=
=Fa8L
-----END PGP SIGNATURE-----

---

----
Join the Frogs!