| Re: [frogs] patch for issue 708 |
[ Thread Index |
Date Index
| More lilynet.net/frogs Archives
]
- To: frogs@xxxxxxxxxxx
- Subject: Re: [frogs] patch for issue 708
- From: Andrew Hawryluk <ahawryluk@xxxxxxxxx>
- Date: Sun, 24 May 2009 22:06:32 -0600
- Cc: lilypond-devel <lilypond-devel@xxxxxxx>
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=BpycgHutK+zGsms4mHve+m5VTKEVvXwNIQZc5SVQcyQ=; b=A7+lHSq3gO6fjBS+LOfjNVwxZt3mAWfWTindcnNAyw6rL5zF5K3Bnj/zOACciB/JKq +wKnkPu3S/nmPX9v8+s4NObI7bEmQyIuMl+aBLD63THDFm5I1J8x/XW8V3sCNvaEadgx COrQ0T803MfJUDrWaRRjr5fXXTXVP1Rx8cVo4=
- Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=OI0HH5ZwY5Nmc/YC68nWojLgCPJLjYkhxKmkh8+OiErK4WdInJws7PoVAfGaeEAOIE QkR40QZD/ZgIhNYN2zRuMyo1WKB+7MwaVj1J8tkEdNuBfvj8GwueAOgV8DvSfDj40GxH KLvUs6USHqnziShu6yoXRMcIIdzxVPOHYUGQI=
On Sun, May 24, 2009 at 7:14 AM, Carl D. Sorensen <c_sorensen@xxxxxxx> wrote:
>
>
>
> On 5/24/09 4:49 AM, "Neil Puttock" <n.puttock@xxxxxxxxx> wrote:
>
>> 2009/5/24 Carl D. Sorensen <c_sorensen@xxxxxxx>:
>>> Thanks, Applied.
>>
>> Unfortunately, there are two serious flaws here:
>>
>> - keySignature alists which aren't backquoted (e.g., the example in
>> the bug tracker) will be ignored
>>
>> - entries of the form (notename . alteration) are mangled:
>>
>> \set Staff.keySignature = #'((0 . 2) (1 . 2) (4 . 2))
>>
>> -> \set Staff.keySignature = #`(((0 . 2) . ,SEMI-SHARP)
>> ((2 . 4) . ,SHARP))
>>
>> Less seriously, the two conversion functions appear to be identical
>> apart from the different dictionaries for alterations. Would it be
>> possible to use a single `fixKS' function with the dictionaries passed
>> as an argument to cut down on the duplication?
>
>
> Thanks for catching this, Neil.
>
> Andrew, I've reverted the patch. Could you rewrite it to fix these issues?
Yes, I'll take a look at it. Thanks, Neil for catching those!
Won't be this week, but I'll keep you posted.
Andrew
---
----
Join the Frogs!