| Re: [frogs] patch for issue 708 |
[ Thread Index |
Date Index
| More lilynet.net/frogs Archives
]
- To: frogs@xxxxxxxxxxx
- Subject: Re: [frogs] patch for issue 708
- From: Neil Puttock <n.puttock@xxxxxxxxx>
- Date: Sun, 24 May 2009 11:49:08 +0100
- Cc: lilypond-devel <lilypond-devel@xxxxxxx>
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=LLTEuLvUw1qoS271j4EPRkPGeyuZ4bsxMWKy2dAA2BA=; b=ewj1s5izwk5y4GAuxmiG1xFq+J63A/fx4c5XjQHdSuV21BqQLYZvrUOt8QMPhkjGen 4U0/QZFefnaMILbQwLZ+MRrq7K8BFHsUXRvBf4Wj1y1C5BjQyFfRtGRD21x0dj0oheFh r2v9M4zjFGwV8De+DfcO7/wc6qXuI+M6BfC1g=
- Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=GvpxCIBIDhX3jlGLHc7B9aX85UHrzN2BTzPFitYeQmnlbFIxjNb5TN6wPls8rY4SyQ ARaLzBnJTTWF3FNdbWIlG5ekSBVpeZxjepdo4ffsxZZF/aig9MMO2z8oTVVS7U0zR35S SMN1UKWUuMJu5CI1GEoCBd6UdrPFLe/q+UuKc=
2009/5/24 Carl D. Sorensen <c_sorensen@xxxxxxx>:
> Thanks, Applied.
Unfortunately, there are two serious flaws here:
- keySignature alists which aren't backquoted (e.g., the example in
the bug tracker) will be ignored
- entries of the form (notename . alteration) are mangled:
\set Staff.keySignature = #'((0 . 2) (1 . 2) (4 . 2))
-> \set Staff.keySignature = #`(((0 . 2) . ,SEMI-SHARP)
((2 . 4) . ,SHARP))
Less seriously, the two conversion functions appear to be identical
apart from the different dictionaries for alterations. Would it be
possible to use a single `fixKS' function with the dictionaries passed
as an argument to cut down on the duplication?
Regards,
Neil
---
----
Join the Frogs!