[frogs] Re: Patch for removing oldaddlyrics function

["Carl D. Sorensen" <c_sorensen@xxxxxxx>]

Ian,

The removal part of the patch looks good.  I question the TODO part a little
bit.  

What do you expect to be done with the TODO?  Do you expect that in the
future somebody will add a doc string to music-functions-init.ly that will
cover the lyric functions?

In my opinion, TODOs should be in the place where future work should begin.
Is that criterion met for this TODO?

Thanks,

Carl


On 2/1/09 2:30 PM, "Ian Hulin" <ian@xxxxxxxxxxxx> wrote:

> Hi Carl,
> 
> Here's a patch to remove the oldaddlyrics function.
>  From delving into the history, it looks like convertly has already done
> stuff with this.in stages:
> 1. A  \newaddlyrics was added
> 2. \addlyrics was -> \oldaddlyrics
> 3. \newaddlyrics -> \addlyrics.
> So I don't think I need to do anything more than change
> music-functions-init.ly.
> 
> Put me right if I'm wrong about this,
> 
> Cheers,
> 
> Ian Hulin


---

----
Join the Frogs!