[frogs] [Fwd: Re: Patch for my bit of Frogs Task 1]

[ Thread Index | Date Index | More lilynet.net/frogs Archives ]


--- Begin Message ---
Hi John,
I originally tried to send the patch as an attachment, but the list moderator bounced the original message because I wasn't subscribed. Here's the patch text as an attachment. I had to generate it here by screen-scraping via the clipboard into Windows notepad, so I'm not sure if I've got the line-endings in the right format for Unix systems. How do I check this on Windows?

Cheers,
Ian


John Mandereau wrote:
Ian Hulin a écrit :
(Apolgoes to the list for this coming late, I'm sorting out my subscription via
gmane)
Hi Carl,

Here's a patch for ny bit of the first Frogs Task, but I've got some questions.

Hi Ian,

I wouldn't have applied your patch as this is up to Carl, but could you resend it either without line breaks or as an attachment? The patch you sent won't apply because of extra line breaks.

Cheers,
John

______________________________________________ This email has been scanned by Netintelligence http://www.netintelligence.com/email
------------------------------------------------------------------------


No virus found in this incoming message.
Checked by AVG - http://www.avg.com Version: 8.0.176 / Virus Database: 270.10.5/1886 - Release Date: 10/01/2009 18:01


Author: Ian Hulin <ian@xxxxxxxxxxxx>  2009-01-09 16:16:40
Committer: Ian Hulin <ian@xxxxxxxxxxxx>  2009-01-09 16:16:40
Parent: 4e0f54f94babca93881e1510865c3e7237ecee0d (Change example for fret diagrams to show opposing-landscape)
Branch: FrogsIanHulin
Follows: release/2.12.1-1
Precedes: 

    Frogs Task 1 - add documentation strings for functions \musicMap to \pageBreak

-------------------------- ly/music-functions-init.ly --------------------------
index a112b67..5dc2d5a 100644
@@ -340,13 +340,23 @@ makeClusters =
 
 musicMap =
 #(define-music-function (parser location proc mus) (procedure? ly:music?)
+(_i "Apply a function operating on a single piece of music to an entire music expression.
+ Usage: @var{proc} The function must be a procedure written in Scheme.  
+        @var{mus} The music expression to which @var{proc} is to be applied.
+	The scheme function will be applied  to each item in the music expression.
+ The function could be used, for example, to apply a series of different articulations 
+ to a repeated section of music" )
 	     (music-map proc mus))
-
-
-
+%
+% TODO Ensure that entries are generated for \addlyrics, \lyricmode \lyricsto
+%      and other lyrics functions
+%
 oldaddlyrics =
 #(define-music-function (parser location music lyrics) (ly:music? ly:music?)
-
+(_i "Obsolete function @code{oldaddlyrics} @var(lyrics) was used to add a block 
+    of lyrics text to a music expression.
+    Please use @code(addlyrics) @var{lyrics} or @code{lyricsto} and 
+    @code{lyricmode) instead.")
               (make-music 'OldLyricCombineMusic 
                           'origin location
                           'elements (list music lyrics)))

--- End Message ---


Mail converted by MHonArc 2.6.19+ http://listengine.tuxfamily.org/