[ Thread Index |
Date Index
| More lilynet.net/frogs Archives
]
- To: frogs@xxxxxxxxxxx
- Subject: Re: [frogs] indentation
- From: Graham Percival <graham@xxxxxxxxxxxxxxxxx>
- Date: Fri, 9 Jan 2009 23:10:13 +0800
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:date:from:to:subject :message-id:references:mime-version:content-type:content-disposition :in-reply-to:user-agent; bh=07DNERvjzBCghHXdtntPVJzgFOzXQIVJ6JKDUptDSx4=; b=Xbyplu2ZkDEzaGwbTmBcwwfwQW5Y9gBSlT4+L4rTeDFnV83wCrL8T88U59H+5MVX/h dGdIl9HvS5BT5MzKvSXaknVRxfhugFhsSoiD6HlIWPvdRk8Rb887k09GH0HMUeEQQDlz lXAem3+olrf/ZevNto23Ubd1eUkbQhIjZ/IUY=
- Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:date:from:to:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; b=R1k0haPBvDqlKeSIeIVpmxoknWAzziivjQ9LBjTlGEp+woscYU9CtzMcZ4UKgXX+Nj RqK3L2ghQM826TvR3MS/Ibrt8VDNj579ZIXavMnHXKzBWXnHwE8AJ/2dK4Es+xR6D71Z LQxUb8f09iCRFudf2Us3eGws0VdqLxBRRL4K4=
On Thu, Jan 08, 2009 at 06:38:53PM -0700, Carl D. Sorensen wrote:
>
> On 1/8/09 2:18 PM, "Valentin Villenave" <v.villenave@xxxxxxxxx> wrote:
>
> > Perhaps "we" (meaning "you guys") could start listing such
> > inconsistencies you may find through the source code... This will make
> > code cleaning easier when the time comes (since I believe code
> > cleaning is also one of the long-term forg's tasks).
>
> I agree. I think we'll have frogs do some "code-janitor" work as described
> in the Request for Help page. But that will be later.
>
> If we're going to do that, I think we should just do it by file. No need to
> track individual occurrences.
For things like tabs vs. spaces, I suggest looking into something
like astyle. First, it's automagic, and second, it's a lot nicer
to see "whitespace changes" in the changelog -- when you're
looking for a bug, you knwo that you can skip over that stuff.
If you think you have nice style options, be it for astyle,
indent, or any other program, check on -devel for both comments on
the automatic style, and for overall permission to modify the
files automatically.
(I can't imagine Han-Wen refusing such permission, but the owner
of my second-biggest open-source project refused it for over a
year. In the end I just did it and dared him to object. It
helped that he was the supervisor for my Master's degree.)
Cheers,
- Graham
---
----
Join the Frogs!