| Re: [chrony-dev] [PATCH v3 5/5] test/unit: add leapdb test |
[ Thread Index |
Date Index
| More chrony.tuxfamily.org/chrony-dev Archives
]
- To: chrony-dev@xxxxxxxxxxxxxxxxxxxx
- Subject: Re: [chrony-dev] [PATCH v3 5/5] test/unit: add leapdb test
- From: Miroslav Lichvar <mlichvar@xxxxxxxxxx>
- Date: Mon, 29 Jan 2024 16:41:06 +0100
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1706542870; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=z4aODaiI1fVUbjHlJAD07go0qigqhE1qK9BlmPIggUY=; b=cNnHWseRP5V70uczW5ZqY2ydS6mcdi1JBpH3+3aQtl0B5fx332OWBAie0OB6ktpuwVhPOr E4rlQwV3LKgOHI1cehWfNXUMedXzvWo8sfbMlQvfEjJVIhuCkI1SjP9Ws8n8K+c3c0CfSm 0JIpZPuZT8rVfBoTR7PYrBv4y+pA9ZU=
On Mon, Jan 29, 2024 at 04:29:00PM +0100, Miroslav Lichvar wrote:
> On Thu, Dec 07, 2023 at 01:17:16PM +1100, patrick.oppenlander@xxxxxxxxx wrote:
> > +void
> > +test_unit(void)
> > +{
> > + char conf[][100] = {
> > + "leapsectz right/UTC",
> > + "leapseclist /usr/share/zoneinfo/leap-seconds.list"
> > + };
>
> The test should not fail on non-glibc systems and when the list file is
> missing. It should skip instead.
For testing the list parsing, maybe it's best to include a cut-down
list with only few entries and few lines of comment (not the full 10KB
file) as leapdb.list directly in the unit test directory, similarly to
the ntp_core.keys file.
--
Miroslav Lichvar
--
To unsubscribe email chrony-dev-request@xxxxxxxxxxxxxxxxxxxx with "unsubscribe" in the subject.
For help email chrony-dev-request@xxxxxxxxxxxxxxxxxxxx with "help" in the subject.
Trouble? Email listmaster@xxxxxxxxxxxxxxxxxxxx.