| Re: [chrony-dev] [PATCH v3 5/5] test/unit: add leapdb test |
[ Thread Index |
Date Index
| More chrony.tuxfamily.org/chrony-dev Archives
]
- To: chrony-dev@xxxxxxxxxxxxxxxxxxxx
- Subject: Re: [chrony-dev] [PATCH v3 5/5] test/unit: add leapdb test
- From: Miroslav Lichvar <mlichvar@xxxxxxxxxx>
- Date: Mon, 29 Jan 2024 16:29:00 +0100
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1706542143; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=IKMrzztV2g1EFmP1VgyvN1QdPjG2B7AT9OoHLl5YZXg=; b=bgU2N3wEQLgbAicsIM/+sxA8qVlvYvN0ptmOO46HO2t7Fphsxh0xshMPj+7EOhQHGCiShS DDtxNE2mjHwq5mkFTmcA68EG4P8su3zk2mYN4B4AclgoQ6RV/ek6FceNMylRmw1i9v0i8s +7IEJEFEYSDGmxc3Tl+otTnM3J7Xlp0=
On Thu, Dec 07, 2023 at 01:17:16PM +1100, patrick.oppenlander@xxxxxxxxx wrote:
> diff --git a/test/unit/leapdb.c b/test/unit/leapdb.c
> +struct test_vector {
> + time_t when;
> + int tai_offset;
> + NTP_Leap leap;
> +} tests[] = {
> + /* From leap-seconds.list */
> + {2272060800, 10, LEAP_Normal}, // 1 Jan 1972
Please use the classic C comment syntax /* */.
> +void
> +test_unit(void)
> +{
> + char conf[][100] = {
> + "leapsectz right/UTC",
> + "leapseclist /usr/share/zoneinfo/leap-seconds.list"
> + };
The test should not fail on non-glibc systems and when the list file is
missing. It should skip instead.
--
Miroslav Lichvar
--
To unsubscribe email chrony-dev-request@xxxxxxxxxxxxxxxxxxxx with "unsubscribe" in the subject.
For help email chrony-dev-request@xxxxxxxxxxxxxxxxxxxx with "help" in the subject.
Trouble? Email listmaster@xxxxxxxxxxxxxxxxxxxx.