| Re: [chrony-dev] [PATCH v2 1/6] reference: move leap second source into leapdb |
[ Thread Index |
Date Index
| More chrony.tuxfamily.org/chrony-dev Archives
]
- To: chrony-dev@xxxxxxxxxxxxxxxxxxxx
- Subject: Re: [chrony-dev] [PATCH v2 1/6] reference: move leap second source into leapdb
- From: Miroslav Lichvar <mlichvar@xxxxxxxxxx>
- Date: Wed, 6 Dec 2023 14:40:11 +0100
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1701870014; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=bmpjbSci9ymqM0x9LWFPpThmLEpS56Shvnb1NXaXSW0=; b=Y6M4lxA7C5wOKNPc4C5R+zPKfpx/p29JTwYpQQwIbM8JPWinG4sYuS+62TQLH48ZFbdWX6 kfs5fEbeZT1l389lxNSXgvicGD2ZmxGnm2q+bMqRajjHzq/vIeSvktE8H5jEEDJqbp1O73 KRekUTv8B0mHVoyPl/4ew6anle2j7lw=
On Thu, Nov 30, 2023 at 02:23:24PM +1100, patrick.oppenlander@xxxxxxxxx wrote:
> +++ b/leapdb.c
> @@ -0,0 +1,147 @@
> +/*
> + chronyd/chronyc - Programs for keeping computer clocks accurate.
> +
> + **********************************************************************
> + * Copyright (C) Patrick Oppenlander 2023
When code is moved, the copyright should be assigned to the author of
the code as reported by git blame.
> +void
> +LDB_Finalise(void)
> +{
> + /* nothing to do */
Just a nit, comments start with capital letter.
> --- a/main.c
> +++ b/main.c
> @@ -57,6 +57,7 @@
> #include "smooth.h"
> #include "tempcomp.h"
> #include "util.h"
> +#include "leapdb.h"
Try to keep the inclusion in alphabetical order.
> +++ b/reference.c
> @@ -36,6 +36,7 @@
> #include "logging.h"
> #include "local.h"
> #include "sched.h"
> +#include "leapdb.h"
Same here.
--
Miroslav Lichvar
--
To unsubscribe email chrony-dev-request@xxxxxxxxxxxxxxxxxxxx with "unsubscribe" in the subject.
For help email chrony-dev-request@xxxxxxxxxxxxxxxxxxxx with "help" in the subject.
Trouble? Email listmaster@xxxxxxxxxxxxxxxxxxxx.