| Re: [chrony-dev] [PATCH v2 3/6] leapdb: move source check into separate function |
[ Thread Index |
Date Index
| More chrony.tuxfamily.org/chrony-dev Archives
]
- To: chrony-dev@xxxxxxxxxxxxxxxxxxxx
- Subject: Re: [chrony-dev] [PATCH v2 3/6] leapdb: move source check into separate function
- From: Miroslav Lichvar <mlichvar@xxxxxxxxxx>
- Date: Wed, 6 Dec 2023 14:43:03 +0100
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1701870188; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+6Hms83ILIuGm2FPHp12DOCeIxkuFUB49tDl4PDUSnw=; b=avlc6JXQm0Lf80dzy6M3ydmZ8sD7lWmgdwCh4i2GAJVZMA/e6rlFJyD0FZN+NsT1l31QmJ h8p/cS3iBOlQI50eZ7EFRcGpx0+sTq0SJEuUOXSYzpsOi9M2VoDh0PcrzCwjeB9UPdaFNA zimiMPI6fXCfxCGKu52Hz9zeYv6Q+wU=
On Thu, Nov 30, 2023 at 02:23:26PM +1100, patrick.oppenlander@xxxxxxxxx wrote:
> /* ================================================== */
>
> +typedef NTP_Leap (*GetLeapFn)(time_t when, int *tai_offset);
> +
I don't like function pointers much. More difficult to follow the
code. Can it be replaced with a condition in LDB_GetLeap?
--
Miroslav Lichvar
--
To unsubscribe email chrony-dev-request@xxxxxxxxxxxxxxxxxxxx with "unsubscribe" in the subject.
For help email chrony-dev-request@xxxxxxxxxxxxxxxxxxxx with "help" in the subject.
Trouble? Email listmaster@xxxxxxxxxxxxxxxxxxxx.