| Re: [chrony-dev] [PATCH 2/2] refclock: Fix poll counting for refclocks that do polling and event driven timekeeping |
[ Thread Index |
Date Index
| More chrony.tuxfamily.org/chrony-dev Archives
]
- To: chrony-dev@xxxxxxxxxxxxxxxxxxxx
- Subject: Re: [chrony-dev] [PATCH 2/2] refclock: Fix poll counting for refclocks that do polling and event driven timekeeping
- From: Miroslav Lichvar <mlichvar@xxxxxxxxxx>
- Date: Thu, 1 Jul 2021 12:56:35 +0200
- Authentication-results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=mlichvar@xxxxxxxxxx
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1625137000; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lGfRXXaEq7T5R0JNzOGWAP0j5E3fK/FH4KGVd1Pu6f4=; b=QRDDBytPZHlYJToR/k5Z8E4i7KCHh9lx6TgPap6tCSThfj9QX/MRdsTDgmJa6FCvQGVXu9 sq820zNMEdtYUTuEKAd+fk/Zpoho2kg8WJduAOUYi2s4x4gQaEwJY8fNLGoV2DalYlbdzf Kfsfa6q53ypEUcr2pZaR/+b+Ldxk+5I=
On Wed, Jun 30, 2021 at 04:47:22PM +0200, Uwe Kleine-König wrote:
> I'm a bit unsure about this change. I wonder what driver_polled actually
> should count. If it counts the number off poll calls the logic in
> RCL_AddCookedPulse and RCL_AddSample are unreliable as they only count
> the events that actually yielded a timestamp?!
With drivers that have poll() it counts the number of its calls to
know when the source poll should be made. In drivers that don't have
poll() it's the number of samples for logging purposes.
This would be the first driver that supports both, so some extension
of the driver API might be needed, e.g. to avoid unneccessary polling,
but I'm not sure how much sense it makes to support irqless RTCs.
chronyd will have a difficult time to synchronize to such a poor
refclock.
--
Miroslav Lichvar
--
To unsubscribe email chrony-dev-request@xxxxxxxxxxxxxxxxxxxx with "unsubscribe" in the subject.
For help email chrony-dev-request@xxxxxxxxxxxxxxxxxxxx with "help" in the subject.
Trouble? Email listmaster@xxxxxxxxxxxxxxxxxxxx.