| Re: [chrony-dev] Re: [PATCH] test: check if RTC is RTC_UIE_ON capable |
[ Thread Index |
Date Index
| More chrony.tuxfamily.org/chrony-dev Archives
]
- To: chrony-dev@xxxxxxxxxxxxxxxxxxxx
- Subject: Re: [chrony-dev] Re: [PATCH] test: check if RTC is RTC_UIE_ON capable
- From: Miroslav Lichvar <mlichvar@xxxxxxxxxx>
- Date: Tue, 10 Dec 2019 17:59:22 +0100
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1575997173; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=U3+5hzMghjZp6UksTer53xo+1M1S8iBdtAnnkD3euvQ=; b=hEHmrKb63/7NHaIxBOfKGeiH0JxND3OJ8wwGF0ZMBULewVxL5Y1Uc9s2aTqMxQrcIcop5+ 4LR2U/aNJQGBZflzrqZ0+vvBt1MwUh5XpUOFZ14fMy+Nsv9F9+9QtoG+ybFdZJxVgCkvKb aEfEcBiEdksfMQp/XSsd/dxnLRbxfBQ=
On Tue, Dec 10, 2019 at 04:25:31PM +0100, Christian Ehrhardt wrote:
> On Tue, Dec 10, 2019 at 4:19 PM Miroslav Lichvar <mlichvar@xxxxxxxxxx>
> > I'm sorry for changing my mind, but I now think this case should be
> > handled gracefully in chronyd and not avoided in the test. According
> > to the man page, the -s option is supposed to work even with no RTC or
> > broken RTCs. A hang or fatal error with the -s option may break
> > the user's expectation.
> >
> > Do you agree?
> >
>
> Yes, but I think the changes are not mutually exclusive and should both be
> added.
>
> -s needs the change you suggested to make the fail fatal.
As I tried to explain in the later post, I think chronyd -s should not
fail if the RTC doesn't support interrupts, as the documentation
implies chronyd can work with "broken" RTCs and we shouldn't expect
the users to test it before configuring chronyd.
> Otherwise users will not realize that they don't get what they ordered.
There will still be the error message in the log.
Can you please try the test again with the latest code?
If you would like, I think it could be improved to prepare an rtcfile
and look for the "System clock off from RTC" message when hwclock
doesn't report that interrupts are not supported.
--
Miroslav Lichvar
--
To unsubscribe email chrony-dev-request@xxxxxxxxxxxxxxxxxxxx with "unsubscribe" in the subject.
For help email chrony-dev-request@xxxxxxxxxxxxxxxxxxxx with "help" in the subject.
Trouble? Email listmaster@xxxxxxxxxxxxxxxxxxxx.